-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-138970: Add general metadata system to the peg generator #138971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed07998 to
12eeca7
Compare
|
I will use this later to make the invalid rules non implicit |
f471328 to
f55196f
Compare
f55196f to
4eeca29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! That's gonna be useful! Left some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
Turns out we only run the tests on Buildbots. |
Uh oh!
There was an error while loading. Please reload this page.